Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5436

Timeout.Infinite is not a good default

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 0.15.0
    • netstd - Library
    • None
    • Patch Available

    Description

      The netstd NamedPIpes implementation uses Timeout.Infinite as the default value, which can be problematic, e.g. if the remote end is not reachable tzhe client will hang forever unless a moire suitable timeout is explicitly specified.

      This patch sets the default to 60 seconds, which is still pretty much (primarily chosen in order to prevent breaking existing code by too aggressive timeouts) but way less than Timeout.Infinite, giving the client a realistic chance to detect the problem before the end of the world comes.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jensg Jens Geyer
            jensg Jens Geyer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment