[THRIFT-5417] Fix Lua compiler omitting default values in Lua service functions

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.15.0
• Component/s: Lua - Compiler
• Patch Info: Patch Available
• Flags: Patch
• External issue URL: https://github.com/apache/thrift/pull/2394
• Assignee: Jeffrey Han
• Reporter: Jeffrey Han
• Created: 18/May/21 20:54
• Updated: 11/Sep/21 12:30
• Resolved: 20/May/21 20:51

Description

Add missing default argument values for service client functions in generated Lua code.

Example Thrift definition:

const string kTestStr = "0"
service SomeService {
  void someMethod(1: string a, 2: string b = kTestStr)
    throws (1: SomeError error)
}

Generated code before:
function SomeServiceClient:send_someMethod(a, b)
  self.oprot:writeMessageBegin('someMethod', TMessageType.CALL, self._seqid)
  local args = someMethod_args:new
  args.a = a
  args.b = b
  args:write(self.oprot)
  self.oprot:writeMessageEnd()
  self.oprot.trans:flush()
end

 

Generated code after:
function SomeServiceClient:send_someMethod(a, b)
  self.oprot:writeMessageBegin('someMethod', TMessageType.CALL, self._seqid)
  local args = someMethod_args:new
  args.a = a
  if b ~= nil then
    args.b = b
  else
    args.b = '0'
  end
  args:write(self.oprot)
  self.oprot:writeMessageEnd()
  self.oprot.trans:flush()
end

Issue Links

• links to: GitHub Pull Request #2394