[THRIFT-5388] Named Pipes transport hardening

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: C++ - Library
• Assignee: Unassigned
• Reporter: Steven
• Created: 01/Apr/21 01:16
• Updated: 06/Apr/21 01:07

Description

In current codes "lib\cpp\src\thrift\transport\TPipe.cpp", the flags to connect the named pipe is always FILE_FLAG_OVERLAPPED. It is not possible to set more security flags to avoid the named pipe server misuse the named pipe client's identify by impersonatenamedpipeclient. Could we provide the API to set these flags? Thanks.

Codes in "TPipe::open()" are listed below:

DWORD flags = FILE_FLAG_OVERLAPPED;
hPipe.reset(CreateFileA(pipename_.c_str(), GENERIC_READ | GENERIC_WRITE, 0, nullptr, OPEN_EXISTING, flags, nullptr));