[THRIFT-5355] Do not rely on compiler and check boundaries

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.15.0
• Component/s: C++ - Library
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 19/Feb/21 07:59
• Updated: 11/Sep/21 12:31
• Resolved: 19/Feb/21 08:09

Description

C++ considers the overflow of a signed integer to be an undefined behavior (even with the "Signed Integers are Two's Complement" update: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0907r1.html ).

Instead of relying on tests(1) to discover if a compiler does not handle the signed integer overflow as we expect it to, we should add an explicit check before incrementing.

(1) See
thrift/lib/cpp/src/thrift/async/TConcurrentClientSyncInfo.cpp

Lines 33 to 34 in c4e899a

	// test rollover all the time
	nextseqid_((std::numeric_limits<int32_t>::max)()-10),

 

Quick check on https://godbolt.org/z/d7W8ds shows that Clang is able to optimize and just do the +1 so modern compilers should be able to keep the same performances where hardware permits.

In addition, some company rules might require code to do just that:
https://wiki.sei.cmu.edu/confluence/display/c/INT32-C.+Ensure+that+operations+on+signed+integers+do+not+result+in+overflow

 

 

Issue Links

• links to: GitHub Pull Request #2305