[THRIFT-5325] Fix Lua library writeStructEnd() in TCompactProtocol

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: Lua - Library
• Patch Info: Patch Available
• External issue URL: https://github.com/apache/thrift/pull/2297
• Assignee: Jeffrey Han
• Reporter: Jeffrey Han
• Created: 17/Dec/20 21:08
• Updated: 11/Feb/21 22:26
• Resolved: 22/Dec/20 01:12

Description

In 0.13.0, two changes were made to the Lua library's TCompactProtocol for writing structs: THRIFT-4992 (writeStructEnd) and THRIFT-5262 (writeStructBegin). Unfortunately these addressed the same issue, so the two changes together just recreated the original problem of corrupt field indices in nested structs.

Revert the change in THRIFT-4992 (and keep the one in THRIFT-5262).

Issue Links

• links to: GitHub Pull Request #2297