Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5318

PHP 8 compatible version of binary protocol

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.15.0
    • PHP - Library
    • None
    • Patch Available

    Description

      PHP 8 has been released and necessitates some changes to PHP extensions. In the case of thrift_protocol these changes are minor:

      • Update callsites of zend_call_method, zend_read_property, and zend_update_property
      • Add arginfo as requested by PHP 8 migration guide (supports reflection features)

      I believe it's possible to do these whilst retaining backwards compatibility with PHP 7; I'll open a PR on Github momentarily.

      Attachments

        Issue Links

          Activity

            People

              tylerchr Tyler Christensen
              tylerchr Tyler Christensen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h 50m
                  2h 50m