[THRIFT-5316] Netstd compiler generates wrong ToString() method: .ToString(sb)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 0.14.0
• Fix Version/s: 0.14.0
• Component/s: netstd - Compiler
• Assignee: Jens Geyer
• Reporter: Konstantin
• Created: 23/Nov/20 10:18
• Updated: 11/Feb/21 22:26
• Resolved: 23/Nov/20 21:30

Description

Thrift compiler generate code that doesn't compile netstd: object doesn't have ToString(StringBuilder) overload. 

Test case: 

struct Test {
  1: string test_string
  2: i64 test_i64
  3: binary test_binary
  4: map<string, string> test_map
} 

produces following ToString() method:

    public override string ToString()
    {
      var sb = new StringBuilder("Test(");
      int tmp6 = 0;
      if((Test_string != null) && __isset.test_string)
      {
        if(0 < tmp6++) { sb.Append(", "); }
        sb.Append("Test_string: ");
        Test_string.ToString(sb);
      }
      if(__isset.test_i64)
      {
        if(0 < tmp6++) { sb.Append(", "); }
        sb.Append("Test_i64: ");
        Test_i64.ToString(sb);
      }
      if((Test_binary != null) && __isset.test_binary)
      {
        if(0 < tmp6++) { sb.Append(", "); }
        sb.Append("Test_binary: ");
        Test_binary.ToString(sb);
      }
      if((Test_map != null) && __isset.test_map)
      {
        if(0 < tmp6++) { sb.Append(", "); }
        sb.Append("Test_map: ");
        Test_map.ToString(sb);
      }
      sb.Append(")");
      return sb.ToString();
    }

Test_string.ToString(sb); (and folllowing .ToString(sb)) - produces build failure: [CS1503] Argument 1: cannot convert from 'System.Text.StringBuilder' to 'System.IFormatProvider?'
 

Full generated class is in attachment