Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5299

rs implementation compact protocol seq_id should not use zigzag encoding.

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.13.0
    • 0.14.1
    • Rust - Library
    • None

    Description

      While reviewing code, I discovered a bug in compact protocol.

      The seq_id in message header is decoded with integer-encoding's i32, which uses zigzag decode implicitly. 

       

       

      EDIT: correct the title and desc.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            allengeorge Allen George
            shuoli84 shuo li
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m

                Issue deployment