Details
-
Task
-
Status: Closed
-
Major
-
Resolution: Fixed
-
0.13.0
-
None
Description
I noticed the issue while writing the example loggingMiddleware code in https://github.com/apache/thrift/pull/1992#issuecomment-705903922. The root cause is that we have two context stacks when implementing TSimpleJSONProtocol in go library, but we never check the slice length before the popping/peeking operations, and in certain circumstances (e.g. calling WriteMessageEnd without matching WriteMessageBegin) it would panic with using -1 as the slice index.
It should return an TProtocolException instead.
Attachments
Issue Links
- links to