[THRIFT-5294] Go: TSimpleJSONProtocol could panic on WriteMessageEnd without matching WriteMessageBegin

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: Go - Library
• Assignee: Yuxuan Wang
• Reporter: Yuxuan Wang
• Created: 11/Oct/20 01:37
• Updated: 11/Feb/21 22:27
• Resolved: 14/Oct/20 17:14

Description

I noticed the issue while writing the example loggingMiddleware code in https://github.com/apache/thrift/pull/1992#issuecomment-705903922. The root cause is that we have two context stacks when implementing TSimpleJSONProtocol in go library, but we never check the slice length before the popping/peeking operations, and in certain circumstances (e.g. calling WriteMessageEnd without matching WriteMessageBegin) it would panic with using -1 as the slice index.

It should return an TProtocolException instead.

Issue Links

• links to: GitHub Pull Request #2258