Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5279

Cleanups/small optimizations for go's serializer/deserializer code

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.14.0
    • Component/s: Go - Library
    • Labels:
      None

      Description

      Currently go's default NewTSerializer and NewTDeserializer implementations use NewTBinaryProtocolFactoryDefault().GetProtocol(transport) to get the protocol. This is essentially the same as NewTBinaryProtocolTransport(transport), but with an extra allocation of the ProtocolFactory that is only used once then discarded. Streamline it will give as a minor performance gain.

      Also I plan to add new constructors for TSerializerPool and TDeserializerPool to make it easier to use with non-default protocols.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                fishywang Yuxuan Wang
                Reporter:
                fishywang Yuxuan Wang
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h