[THRIFT-5252] Make CreateHttpClientHandler() method virtual

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: netstd - Library
• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 14/Jul/20 13:33
• Updated: 11/Feb/21 22:26
• Resolved: 14/Jul/20 19:43

Description

The CreateHttpClientHandler() factory method of THttpTransport should be virtual instead of static. This allows overriding the method and manipulating the returned handler. Amongst others, one possible use case could be to relax the SSL/TLS validation checks intentionally for some custom purpose, like so:

public class TCustomizedHttpTransport : THttpTransport
{
	public override HttpClientHandler CreateHttpClientHandler(X509Certificate[] certs = null)
	{
		var handler = base.CreateHttpClientHandler(certificates);
		handler.ServerCertificateCustomValidationCallback = MyCallback;
		return handler;
	}

	private bool MyCallback(object s, X509Certificate crt, X509Chain ch, SslPolicyErrors e)
	{
		var other_errors = e & (~SslPolicyErrors.RemoteCertificateNameMismatch);
		return (SslPolicyErrors.None == other_errors);
	}
}

 

Issue Links

• links to: GitHub Pull Request #2201