[THRIFT-5211] Handle incomplete reads correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: Haskell - Library
• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 17/May/20 12:42
• Updated: 11/Feb/21 22:27
• Resolved: 17/May/20 13:24

Description

From https://github.com/apache/thrift/pull/2108

The read functions for handles promise to return up to the requested number of bytes. This means in case we read less bytes, we should try again to read some more bytes. This issue caused invalid frame sizes which caused arbitrary decoding failures.

I believe that the bug has been introduced in 3c42007

Issue Links

• links to: GitHub Pull Request #2108