[THRIFT-5160] Swift: generated processor does work for extended classes

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.14.0
• Component/s: Swift - Compiler
• Assignee: Unassigned
• Reporter: Jano Svitok
• Created: 01/Apr/20 13:58
• Updated: 01/Apr/20 13:59

Description

Let's say we have following IDL:

service service1 {
 void func1()
}

service service2 extends service1 {
 void func2()
}

compiler generates processor for service2:

extension service2Processor : TProcessor {
  static let processorHandlers: ProcessorHandlerDictionary = {
    var processorHandlers = ProcessorHandlerDictionary()
    processorHandlers["func2"] = { sequenceID, inProtocol, outProtocol, handler in
       // ...processor for func2
    }
    return processorHandlers
  }()

  public func process(on inProtocol: TProtocol, outProtocol: TProtocol) throws {
    let (messageName, _, sequenceID) = try inProtocol.readMessageBegin()
    if let processorHandler = service2Processor.processorHandlers[messageName] {
       // ...process the message
    }
    else {
       // ...unknown message
    }
  }
}

This processor will not process func1 since it's not in processorHandlers[].

Issue Links

• is related to: THRIFT-3325 Extended services aren't subclasses in generated Cocoa