Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5155

Swift 5.1 support

    XMLWordPrintableJSON

Details

    Description

      Xcode 11.3 (Swift 5.1) generates deprecation warnings for:

      • Hashable protocol conformance using new Hasher type
      • Use of `withUnsafeBytes`

      `TAsyncResult<T>` is also redundant with the advent of `Result<T, Error>` in the stdlib.

      The linked PR addresses all of the above and removes old versions of Swift from the CI job.

      Attachments

        Issue Links

          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. THRIFT-5070 Swift: Hashable.hashValue is deprecated as a protocol requirement

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link GitHub Pull Request #2073

          Activity

            People

              alexanderedge Alexander Edge
              alexanderedge Alexander Edge
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10m
                  10m