Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5137

Version 0.13.0 require CMake 3.10 or higher

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 0.13.0
    • None
    • C++ - Library
    • None

    Description

      The "include_guard" function was introduced in CMake 3.10

      https://github.com/apache/thrift/blob/master/build/cmake/FindClangTools.cmake#L11

      Since library builders don't need to use clang-tidy it seems like you shouldn't want the build to fail like this.

      Example failure

      https://github.com/apache/arrow/pull/6572/checks?check_run_id=499747124

      Attachments

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. ARROW-8049 [C++] Upgrade bundled Thrift version to 0.13.0

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link Apache Arrow PR #6572

          Activity

            People

              Unassigned Unassigned
              wesm Wes McKinney
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: