[THRIFT-5133] TCompactProtocol string allocation improvement

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: netstd - Library
• Assignee: Mikel Blanchard
• Reporter: Mikel Blanchard
• Created: 05/Mar/20 00:03
• Updated: 11/Feb/21 22:26
• Resolved: 19/Mar/20 22:28

Description

WriteStringAsync & ReadStringAsync in TCompactProtocol each allocate a buffer to store UTF8 bytes when converting to and from strings. This buffer has to be cleaned up by the garbage collector (at some point), which can lead to a lot of pressure on the hosting process in high-volume scenarios. Basically a lot of short-lived buffers are being emitted by the library. It's an easy tweak to use a pooled buffer for this work which greatly improves the performance under load.

Issue Links

• links to: GitHub Pull Request #2043
• links to: GitHub Pull Request #2057