Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5128

Swift TFramedTransport does not work using present code

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.14.0
    • 0.14.0
    • Swift - Compiler
    • None

    Description

      These are TFrameTransport related issues from THRIFT-5125.

       

      1. TFramedTransport.flush is not called anywhere; therefore, the message is never sent. outProtocol.transport.flush should be added to generated processors after outProtocol.writeMessageEnd, and also after writeException.
      2. TFramedTransport.remainingBytes are not reset anywhere, thus the header of second and further messages are not processed properly
      3. TFramedTransport.flush incorrectly checks if buffer >= headerSize (got there by incorrectly porting code COCOA lib)
      4. TFramedTransport does not read the whole message from the underlaying transport at once (that I understand is the whole point of TFramedTransport)

      Notes:

      • 1. needs compiler changes

      PR: https://github.com/apache/thrift/pull/2047

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            janosvitok Jano Svitok
            janosvitok Jano Svitok
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                Issue deployment