Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-511

Better performing hash method for generated structs

    XMLWordPrintableJSON

Details

    • New Feature
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.2
    • Ruby - Library
    • None
    • Patch Available

    Description

      As discussed in THRIFT-231, ruby generated structs' hash code method just always returns zero. While this is semantically correct, it leads to hashes having O performance instead of O(1), which is critical for some applications.

      We can either take the approach that the Java library uses (optionally produce complex hash function), or just generate a good hash all the time.

      Attachments

        1. thrift-511.patch
          0.6 kB
          Dan Kinder

        Activity

          People

            dkinder Dan Kinder
            bryanduxbury Bryan Duxbury
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: