[THRIFT-5114] Simplify the computation of the size of TMemoryBuffer

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: C++ - Library
• Assignee: Mario Emmenlauer
• Reporter: Mario Emmenlauer
• Created: 24/Feb/20 14:31
• Updated: 16/Jun/23 13:16
• Resolved: 03/Jun/20 21:11

Description

The updated size of TMemoryBuffer is currently computed in a loop. This is a bit hard to read, i.e. it is not very clear what the size will be updated to or what policy this follows. The computed sizes are not necessarily powers of two, but rather arbitrary sizes.

I propose to simplify this to an explicit formula that allocates a size equal to the next larger power of two.

Issue Links

• causes: THRIFT-5716 TMemoryBuffer resizing might shrink the buffer size due to uint32_t overflow
• links to: GitHub Pull Request #2030