Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5068

CI is broken due to http://repo1.maven.org

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • Build Process
    • None

    Description

      Upstream has removed support for HTTP based access. I've updated all references I could find, but the build is still broken as we somehow still have references to the HTTP endpoint.

      jensg any ideas?

      Attachments

        Issue Links

          Activity

            dcelasun Duru Can Celasun added a comment - This has effected other Apache projects as well: https://issues.apache.org/jira/browse/THRIFT-5068?jql=summary%20~%20%22repo1.maven.org*%22%20OR%20description%20~%20%22repo1.maven.org*%22%20ORDER%20BY%20created%20DESC
            ctubbsii Christopher Tubbs added a comment - - edited

            This is likely caused by some dependencies defining their own "repositories" section in their own POM, with the insecure Maven Central URL defined in those.

            You may be able to fix this in your .m2/settings.xml by defining a "mirrorOf" for any such references in dependency POMs. You'll have to figure out all the various names of the repositories defined in the dependencies (usually, it's "central" or similar). You could add a "mirrorOf" for *, but that will probably mess up some legitimate ones.

            Details on how to configure a mirror are here: https://maven.apache.org/guides/mini/guide-mirror-settings.html

            And, it is very easy to have a pre-install step place a custom .m2/settings.xml file in Travis CI, too. See, for example: https://github.com/apache/accumulo/blob/99e3023c7f96a2553282dc73cffdf82659285d2d/.travis.yml#L34-L37

            ctubbsii Christopher Tubbs added a comment - - edited This is likely caused by some dependencies defining their own "repositories" section in their own POM, with the insecure Maven Central URL defined in those. You may be able to fix this in your .m2/settings.xml by defining a "mirrorOf" for any such references in dependency POMs. You'll have to figure out all the various names of the repositories defined in the dependencies (usually, it's "central" or similar). You could add a "mirrorOf" for * , but that will probably mess up some legitimate ones. Details on how to configure a mirror are here: https://maven.apache.org/guides/mini/guide-mirror-settings.html And, it is very easy to have a pre-install step place a custom .m2/settings.xml file in Travis CI, too. See, for example: https://github.com/apache/accumulo/blob/99e3023c7f96a2553282dc73cffdf82659285d2d/.travis.yml#L34-L37

            Thanks, that does seem to be the cause. I won't have time to investigate this in the next few weeks, so PRs are appreciated.

            dcelasun Duru Can Celasun added a comment - Thanks, that does seem to be the cause. I won't have time to investigate this in the next few weeks, so PRs are appreciated.

            It was hard to figure out the Docker setup Thrift is using in its Travis CI configuration, but I think https://github.com/apache/thrift/pull/1988 might work. Not sure if the file I changed is used for CI only or if it's used by users too (if so, it could mess up their existing settings.xml file).

            ctubbsii Christopher Tubbs added a comment - It was hard to figure out the Docker setup Thrift is using in its Travis CI configuration, but I think https://github.com/apache/thrift/pull/1988 might work. Not sure if the file I changed is used for CI only or if it's used by users too (if so, it could mess up their existing settings.xml file).

            Thanks for the PR! Travis is all green now.

            dcelasun Duru Can Celasun added a comment - Thanks for the PR! Travis is all green now.

            Glad to help.

            ctubbsii Christopher Tubbs added a comment - Glad to help.

            People

              ctubbsii Christopher Tubbs
              dcelasun Duru Can Celasun
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m