[THRIFT-5050] Fix MemoryBuffer.pm to raise a proper exception if no data is available

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: Perl - Library
• Assignee: Kengo Seki
• Reporter: Kengo Seki
• Created: 26/Dec/19 05:33
• Updated: 11/Feb/21 22:27
• Resolved: 28/Jan/20 22:28

Description

MemoryBuffer.pm is implemented as follows, but it doesn't raise a TTransportException when no data is available.

lib/perl/lib/Thrift/MemoryBuffer.pm

113 sub readAll
114 {
115     my $self = shift;
116     my $len  = shift;
117
118     my $avail = ($self->{wPos} - $self->{rPos});
119     if ($avail < $len) {
120         die TTransportException->new("Attempt to readAll($len) found only $avail available",
121                                     Thrift::TTransportException::END_OF_FILE);
122     }
123

Instead, it dies due to a wrong package name as follows. The right name is Thrift::TTransportException.

$ perl -Ilib -de 1

(snip)

  DB<1> use Thrift::BinaryProtocol

  DB<2> use Thrift::MemoryBuffer

  DB<3> $trans = Thrift::MemoryBuffer->new

  DB<4> $proto = Thrift::BinaryProtocol->new($trans)

  DB<5> $s

  DB<6> $proto->readString(\$s)
Can't locate object method "new" via package "TTransportException" (perhaps you forgot to load "TTransportException"?) at lib/Thrift/MemoryBuffer.pm line 120.

Issue Links

• links to: GitHub Pull Request #1967