[THRIFT-5046] Custom tags remove db and json tags

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: Go - Compiler
• Assignee: Duru Can Celasun
• Reporter: Duru Can Celasun
• Created: 12/Dec/19 10:01
• Updated: 11/Feb/21 22:27
• Resolved: 13/Dec/19 13:10

Description

Given the IDL:

struct Example {
  1: bool withTag (go.tag = "foo:\"bar\"")
  2: bool withoutTag
}

The generated code looks like:

type Example struct {
  WithTag bool `thrift:"withTag,1", foo:"bar"`
  WithoutTag bool `thrift:"withoutTag,2" db:"withoutTag" json:"withoutTag"`
}

The bug is on this line of the Go generator where any custom tag overwrites the existing db and json tags.

Custom tags that aren't overrides should be appended instead of replacing the whole thing.

Issue Links

• links to: GitHub Pull Request #1963