[THRIFT-5016] Do Not Check 'other' For Null in Equals

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: Java - Compiler
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 18/Nov/19 14:45
• Updated: 11/Feb/21 22:26
• Resolved: 28/Jan/20 21:54

Description

  @Override
  public boolean equals(java.lang.Object that) {
    if (that == null)
      return false;
    if (that instanceof CrossPlatformResource)
      return this.equals((CrossPlatformResource)that);
    return false;
  }

There is a null check before instanceof. This check is superfluous:

https://stackoverflow.com/questions/2950319/is-null-check-needed-before-calling-instanceof

Issue Links

• links to: GitHub Pull Request #1937