Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5002

remote client fails to compile when extending services

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.14.0
    • Component/s: Go - Compiler
    • Labels:
      None

      Description

      For example, for this test case (also available in github.com/johnboiles/golang-fix-container-struct-remote)

      service container_test_base {
          void setfunc(1: set<i32> s)
      }
      
      service container_test extends container_test_base {
      }
      

      This error occurs when compiling the Go code

      gopath/src/servicestest/container_test-remote/container_test-remote.go:163:25: undefined: servicestest.NewContainerTestSetfuncArgs
      

      That is because there is no generated code for NewContainerTestSetfuncArgs but instead only NewContainerTestBaseSetfuncArgs. We should probably fix this either by also generating NewContainerTestSetfuncArgs or using NewContainerTestBaseSetfuncArgs from the remote client for the derived service.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                johnboiles John Boiles
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m