[THRIFT-5002] remote client fails to compile when extending services

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: Go - Compiler
• Assignee: Unassigned
• Reporter: John Boiles
• Created: 09/Nov/19 00:10
• Updated: 11/Feb/21 22:27
• Resolved: 09/Nov/19 19:23

Description

For example, for this test case (also available in github.com/johnboiles/golang-fix-container-struct-remote)

service container_test_base {
    void setfunc(1: set<i32> s)
}

service container_test extends container_test_base {
}

This error occurs when compiling the Go code

gopath/src/servicestest/container_test-remote/container_test-remote.go:163:25: undefined: servicestest.NewContainerTestSetfuncArgs

That is because there is no generated code for NewContainerTestSetfuncArgs but instead only NewContainerTestBaseSetfuncArgs. We should probably fix this either by also generating NewContainerTestSetfuncArgs or using NewContainerTestBaseSetfuncArgs from the remote client for the derived service.

Issue Links

• links to: GitHub Pull Request #1925