Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4994

TWebSocketTransport false scope in forEach in browser

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.14.0
    • Component/s: Node.js - Library
    • Labels:
      None
    • Environment:

      Webpack 4.41.2

      Thrift 0.13.0

      NodeJS thrift lib required in browser env

       

    • Patch Info:
      Patch Available
    • Flags:
      Patch, Important

      Description

      NodeJS Client in browser with Bundler (e.g. Webpack)

      When importing/requiring TWebSocketTransport for use in browser, the function throws an error if some call were made before the connection was fully open. 

      Wrong scope in foreach with `this`

        Attachments

          Activity

            People

            • Assignee:
              alabama Eugen Kandakov
              Reporter:
              alabama Eugen Kandakov

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                  Issue deployment