[THRIFT-4994] TWebSocketTransport false scope in forEach in browser

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: Node.js - Library

Environment

Webpack 4.41.2

Thrift 0.13.0

NodeJS thrift lib required in browser env

 

• Patch Info: Patch Available
• Flags: Patch, Important
• Assignee: Eugen Kandakov
• Reporter: Eugen Kandakov
• Created: 04/Nov/19 12:18
• Updated: 11/Feb/21 22:27
• Resolved: 04/Nov/19 21:02

Description

NodeJS Client in browser with Bundler (e.g. Webpack)

When importing/requiring TWebSocketTransport for use in browser, the function throws an error if some call were made before the connection was fully open. 

Wrong scope in foreach with `this`

Issue Links

• links to: GitHub Pull Request #1918