[THRIFT-4940] value should inialization when defined

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Not A Problem
• Affects Version/s: 0.13.0
• Fix Version/s: 0.13.0
• Component/s: Compiler (General)

Environment

win7, visual studio 2015, thrift-master

• Assignee: Jens Geyer
• Reporter: pengzhouhu
• Created: 27/Aug/19 03:20
• Updated: 10/Oct/19 22:53
• Resolved: 27/Aug/19 22:04

Description

i debug the compiler in compiler\cpp\src\thrift\generate\main.cc line 169, values should inialization before beused. a little improvement i suggest.

/**
 * Win32 doesn't have realpath, so use fallback implementation in that case,
 * otherwise this just calls through to realpath
 */
char* saferealpath(const char* path, char* resolved_path) {
#ifdef _WIN32
  char buf[MAX_PATH];
  char* basename;
  DWORD len = GetFullPathNameA(path, MAX_PATH, buf, &basename);
  if (len == 0 || len > MAX_PATH - 1) {
    strcpy(resolved_path, path);
  } else {
    strcpy(resolved_path, buf);
  }

  // Replace backslashes with forward slashes so the
  // rest of the code behaves correctly.
  size_t resolved_len = strlen(resolved_path);
  for (size_t i = 0; i < resolved_len; i++) {
    if (resolved_path[i] == '\\') {
      resolved_path[i] = '/';
    }
  }
  return resolved_path;
#else
  return realpath(path, resolved_path);
#endif
}

thanks.
zhouhu.

Issue Links

• links to: GitHub Pull Request #1856