Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4920

Binary constants emit non-binary Python literals

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.12.0
    • 0.13.0
    • Python - Compiler
    • None

    Description

      Currently a binary constant declared as

      const binary FOO = "bar"

      would generate a regular string constant in Python:

      FOO = "bar"

      which is not really a binary string.  Instead a bytestring literal should be generated:

      FOO = b"bar"

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            elprans Elvis Pranskevichus
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                Slack

                  Issue deployment