Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4919

THttpTransport.cs (netstd) and THttpClientTransport (netcore) have bad timeout code

    XMLWordPrintableJSON

    Details

      Description

      THttpTransport.cs (netstd) and THttpClientTransport (netcore) have the same identical and badly written timeout configuration code.

      1. the code is using Timespan.FromSeconds(), yet the coder wants the variable to be using milliseconds
      2. the timeout is permanently set to the class initialized value since the timeout is only used within constructor, rendering the property useless

      Incidentally, there's no way to configure timeout except for using reflection.

      Also, if the ConnectTimeout property is NOT readable, how can people determine what's used for the timeout?  It should be readable too.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jensg Jens Geyer
                Reporter:
                atam Al Tam
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m