[THRIFT-4919] THttpTransport.cs (netstd) and THttpClientTransport (netcore) have bad timeout code

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.13.0
• Component/s: netcore - Library, netstd - Library
• Assignee: Jens Geyer
• Reporter: Al Tam
• Created: 06/Aug/19 16:04
• Updated: 19/Jun/20 09:22
• Resolved: 20/Aug/19 19:36

Description

THttpTransport.cs (netstd) and THttpClientTransport (netcore) have the same identical and badly written timeout configuration code.

1. the code is using Timespan.FromSeconds(), yet the coder wants the variable to be using milliseconds
2. the timeout is permanently set to the class initialized value since the timeout is only used within constructor, rendering the property useless

Incidentally, there's no way to configure timeout except for using reflection.

Also, if the ConnectTimeout property is NOT readable, how can people determine what's used for the timeout?  It should be readable too.

Issue Links

• causes: THRIFT-5236 THttpTransport.cs still has bad timeout code
• links to: GitHub Pull Request #1847