Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-491

Ripping raw pthreads out of TFileTransport and associated test issues

    XMLWordPrintableJSON

Details

    • Question
    • Status: Closed
    • Major
    • Resolution: Not A Problem
    • 0.1
    • 0.9
    • C++ - Library
    • None
    • Mac OS X 10.5.6

    Description

      The last piece of replacing the pthread-based threading implementation with a Boost threads implementation is to replace all of the raw ptherad mutex and condition usage in TFileTransport.

      I think the best way to proceed is to define a Condition class, similar to the way there is a Mutex class defined, give it a generic API that satisfies the demands of TFileTransport, then implement it both ways. You would need to construct a Condition object with a Mutex object reference, or probably a weak_ptr<Mutex> so we can know that the condition waits are safe. I'll add a comment with the API I work out.

      However, my main concern is how to test the new code. It looks like I can use stress-test, but iI was hoping that someone who is familiar with the app could give me some pointers or a test procedure that exercises the threading code.

      Attachments

        Activity

          People

            jfarrell Jake Farrell
            rush Rush Manbert
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: