[THRIFT-4845] PHP's TCurlClient ignores timeout values smaller that 1 second

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: PHP - Library

Environment

PHP 7.*

• Assignee: James E. King III
• Reporter: Jeremy Mikkola
• Created: 05/Apr/19 00:56
• Updated: 16/Oct/19 22:26
• Resolved: 14/May/19 10:16

Description

Presently, if you specify a fractional timeout (e.g. 0.2) with setTimeoutSecs(), it is ignored and the request is allowed to take an arbitrary amount of time.

 

Specifying integer timeouts works as expected (e.g. 1, 2, or more seconds).

 

This happens because this line uses CURLOPT_TIMEOUT instead of CURLOPT_TIMEOUT_MS.

 

I have a patch I'll submit after creating this  ticket.

Issue Links

• links to: GitHub Pull Request #1776