[THRIFT-4838] Swift TSocketTransport implementation is missing unix domain socket support

• Type: Bug
• Status: In Progress
• Priority: Major
• Resolution: Unresolved
• Component/s: Swift - Library
• Assignee: Kino
• Reporter: Kevin Wojniak
• Created: 22/Mar/19 05:32
• Updated: 06/Mar/23 18:31

Description

TSocketTransport in Objective-C supports initWithPath: for unix domain sockets:
https://github.com/apache/thrift/blob/f3ec277e7e2c147342831ecec590bc2f71b07761/lib/cocoa/src/transport/TSocketTransport.m#L82

However since the Objective-C implementation has been removed in 0.13, the Swift version does not implement this:
https://github.com/apache/thrift/blob/master/lib/swift/Sources/TSocketTransport.swift

Before this is done I think TCFSocketTransport should be moved to its own file. This would avoid extra #if logic to prevent Linux compiling, and simplify the code.

 

Issue Links

• links to: GitHub Pull Request #2766