[THRIFT-4825] Align TTlsServerSocketTransport constructors with TServerSocketTransport - Breaking Change

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.13.0
• Component/s: netstd - Library
• Assignee: Kyle Smith
• Reporter: Kyle Smith
• Created: 15/Mar/19 11:23
• Updated: 16/Oct/19 22:27
• Resolved: 15/Mar/19 22:01

Description

Currently, you are unable to pass in your own TcpListener object when creating a TTlsServerSocketTransport instance in the same fashion as a TServerSocketInstance. Without this we're not able to bind to any address other than IPAddress.Any (0.0.0.0). By normalizing the constructors like in THRIFT-4821 you can add this option without increasing the amount of constructors to maintain.

This could be considered a breaking change since moving the default value for the buffering parameter after the certificate would change it's signature.

Issue Links

• links to: GitHub Pull Request #1762