Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4816

JSONTransports Context.WriteAsync/ReadAsync are badly named

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.13.0
    • netstd - Library
    • None

    Description

      It's hard to tell what Context.WriteAsync() does in the following example unless one looks at the implementations.

      private async Task WriteJsonObjectStartAsync(CancellationToken cancellationToken)
      {
              await Context.WriteAsync(cancellationToken);
              await Trans.WriteAsync(TJSONProtocolConstants.LeftBrace, cancellationToken);
              PushContext(new JSONPairContext(this));
      }
       

       

       

      Attachments

        Issue Links

          Activity

            People

              jensg Jens Geyer
              jensg Jens Geyer
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m