[THRIFT-4816] JSONTransports Context.WriteAsync/ReadAsync are badly named

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: netstd - Library
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 11/Mar/19 23:55
• Updated: 16/Oct/19 22:27
• Resolved: 19/Apr/19 14:09

Description

It's hard to tell what Context.WriteAsync() does in the following example unless one looks at the implementations.

private async Task WriteJsonObjectStartAsync(CancellationToken cancellationToken)
{
        await Context.WriteAsync(cancellationToken);
        await Trans.WriteAsync(TJSONProtocolConstants.LeftBrace, cancellationToken);
        PushContext(new JSONPairContext(this));
}
 

 

 

Issue Links

• links to: GitHub Pull Request #1779