Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4803

Fix 64-bit nodejs math by switching from node-int64 to long or bignum

    XMLWordPrintableJSON

Details

    Description

      The package node-int64 allows for storage of 64-bit integers but it does not allow for integer arithmetic. There are solutions for this, for example the packages long, bignum, bigint. We should switch to one of these, even though it is a breaking change, as it improves i64 behavior. This would be a breaking change; folks can continue to use 0.12.0 if they don't want to change their code.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-4214 map<i64,value> key treated as hex value in JavaScript

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-4675 JS code generators not handling int64 type properly for constants and for TypeScript type mappings

          • Major - Major loss of function.
          • Closed

          Activity

            People

              Unassigned Unassigned
              jking3 James E. King III
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: