[THRIFT-4762] C++: Applied some C++11 refactorings to the runtime library and compiler

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: C++ - Compiler, C++ - Library, Tutorial
• Labels: Breaking-Change
• Assignee: James E. King III
• Reporter: Sebastian Zenker
• Created: 28/Jan/19 10:40
• Updated: 16/Oct/19 22:27
• Resolved: 29/Jan/19 14:48

Description

I basically used clang-tidy to apply the following C++11 refactorings (which make very much sense to me)

• make use of override keyword whenever a virtual function is overwritten
• make use of auto keyword for iterators
• make use of auto keyword when every a redundancy can be avoided, e.g. 
  uint32_t len = static_cast<uint32_t>(str.length());
  auto len = static_cast<uint32_t>(str.length());
• replaced NULL with nullptr
• make use of explicitly-defaulted function definition

Additionally, I applied some more const-correctness to some functions.

Issue Links

• links to: GitHub Pull Request #1719