Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4758

We gitignore and do not check in config lock files in many languages - isn't that bad?

    XMLWordPrintableJSON

Details

    Description

      In npm we check in the package-lock.json file because that ensures your builds are stable over time. The cost you pay is that occasionally you need to rev the file manually. The benefit is a changed package won't bork your build.

      I have identified in the following languages we are ignoring and not checking in the package lock files:

      d (dub)
      dart
      php (top level composer.jock)
      ruby
      rust

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. THRIFT-4019 Dart Makefiles should also clean pubspec.lock

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. THRIFT-4460 php library use PSR-2

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              Unassigned Unassigned
              jking3 James E. King III
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: