[THRIFT-4752] Add cmake package configuration support?

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Duplicate
• Component/s: Deployment
• Labels: cmake
• Assignee: James E. King III
• Reporter: Mario Emmenlauer
• Created: 24/Jan/19 13:40
• Updated: 21/Mar/19 22:31
• Resolved: 15/Mar/19 11:35

Description

The thrift build with cmake is really great! In my daily use, there is a minor issue left: downstream packages all have to have a FindThrift.cmake script. This is slightly annoying, because it replicates the same detection script over and over in all downstream packages.

Modern cmake suggests a nice solution: the use of package configuration files (see https://cmake.org/cmake/help/v3.0/manual/cmake-packages.7.html#package-configuration-file). With package configuration files, after building thrift, downstream packages can just use

find_package(thrift)

and the library and compiler are "auto-magically" resolved. Transitive package dependencies are also resolved, and even build settings like compiler flags can be passed on.

I have created a package configuration for thrift cmake build. Could this be considered for inclusion?

Issue Links

• is duplicated by: THRIFT-4811 Add cmake config module
• relates to: THRIFT-4811 Add cmake config module
• links to: GitHub Pull Request #1709
• links to: GitHub Pull Request #1748