Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4752

Add cmake package configuration support?

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Duplicate
    • None
    • None
    • Deployment

    Description

      The thrift build with cmake is really great! In my daily use, there is a minor issue left: downstream packages all have to have a FindThrift.cmake script. This is slightly annoying, because it replicates the same detection script over and over in all downstream packages.

      Modern cmake suggests a nice solution: the use of package configuration files (see https://cmake.org/cmake/help/v3.0/manual/cmake-packages.7.html#package-configuration-file). With package configuration files, after building thrift, downstream packages can just use

      find_package(thrift)

      and the library and compiler are "auto-magically" resolved. Transitive package dependencies are also resolved, and even build settings like compiler flags can be passed on.

      I have created a package configuration for thrift cmake build. Could this be considered for inclusion?

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jking3 James E. King III
            emmenlau Mario Emmenlauer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 0.5h
                0.5h

                Issue deployment