[THRIFT-4714] Java TFramedTransport calls write twice for each flush

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.6
• Fix Version/s: 0.13.0
• Component/s: Java - Library
• Assignee: James E. King III
• Reporter: James E. King III
• Created: 03/Jan/19 04:31
• Updated: 16/Oct/19 22:26
• Resolved: 04/Jan/19 03:05

Description

Code calls two writes to the underlying transport per flush: one for the frame size and one for the payload. The result is that folks use TBufferedTransport on top of TFramedTransport to avoid getting two ethernet frames for small packets. This means everything is double-buffered!

Based on THRIFT-1121 and THRIFT-959 this may have been an issue for a long time - the fix was easy however. We make room for the frame size before writing to the buffer, then we only have to pull out the buffer, drop the frame size into the 4 bytes that we pre-allocated, and then write to the underlying transport once.

Issue Links

• is duplicated by: THRIFT-1423 Binary transport break up by overlapping of TFrame headers in scribe.AsyncClient
• relates to: THRIFT-1121 Java server performance regression in 0.6
• relates to: THRIFT-959 TSocket seems to do its own buffering inefficiently
• links to: GitHub Pull Request #1671