[THRIFT-4709] Use StandardCharset UTF-8

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.13.0
• Component/s: Java - Library
• Labels: Breaking-Change
• Assignee: James E. King III
• Reporter: David Mollitor
• Created: 31/Dec/18 21:42
• Updated: 16/Oct/19 22:27
• Resolved: 03/Jan/19 05:10

Description

AS I understand it, starting with Java 1.7, all JVM must support the UTF-8 charset. Prior to JDK 7, it was required to do something like:

TJSONProtocol.java

    try {
      byte[] buf = str.getBytes("UTF-8");
      trans_.write(buf);
    } catch (UnsupportedEncodingException uex) {
      throw new TException("JVM DOES NOT SUPPORT UTF-8");
    }

However, now there is available java.nio.charset.StandardCharsets which provides the required charsets and therefore there is no longer a need to do a try/catch to encode/decode Strings and UTF-8 byte arrays. This will save on lines of code and removes the overhead of the try/catch block.

Issue Links

• is blocked by: THRIFT-4694 Upgrade Java to Java 1.8
• links to: GitHub Pull Request #1662