[THRIFT-4672] IAsyncResult style methods not being supported by certain transports leads to issues in mixed ISync/IAsync use cases

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.12.0
• Component/s: C# - Compiler
• Labels: async
• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 23/Nov/18 00:57
• Updated: 27/Dec/18 15:25
• Resolved: 24/Nov/18 20:50

Description

The csharp:async switch causes the compiler to change the implementation of the client side call stubs to always use IAsyncResult. This causes issues, because the IAsyncResult call style is not supported by all transports.

If such a transport is used, the code finally calls the TTransport implementations of BeginFlush and EndFlush - either one of these simply throws an exception, causing the outgoing call to fail.

What is highly unexpected here is the fact, that due to the send_Xxx method implementation change also ISync interface is affected as soon as csharp:async is used.