[THRIFT-4662] Rust const string calls function at compile time

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: Rust - Compiler

Environment

C:\Users\jake>rustup show
Default host: x86_64-pc-windows-msvc

stable-x86_64-pc-windows-msvc (default)
rustc 1.30.0 (da5f414c2 2018-10-24)

• Assignee: Allen George
• Reporter: J W
• Created: 07/Nov/18 06:51
• Updated: 27/Dec/18 15:24
• Resolved: 12/Nov/18 12:51

Description

For this thrift:

const string broker_playback_message = "mmi.developer.playback"

Generates:

// thrift -gen rs -out ../rust/thrift/src const_string.thrift

pub const BROKER_PLAYBACK_MESSAGE: String = "mmi.developer.playback".to_owned();

Fails to compile:

error[E0015]: calls in constants are limited to tuple structs and tuple variants
note: a limited form of compile-time function evaluation is available on a nightly compiler via `const fn`

Fix:

Probably want to output:

pub const BROKER_PLAYBACK_MESSAGE: &str = "mmi.developer.playback";

 

Looking at render_const_value() it looks like byte arrays will have the same issue.

 

Issue Links

• links to: GitHub Pull Request #1624