[THRIFT-4648] c_glib namespaces incorrect includes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: C glib - Compiler

Environment

Thrift from GIT

$ ../build/compiler/cpp/bin/thrift --version
Thrift version 1.0.0-dev

OS:

$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04.1 LTS"

• Assignee: Simon South
• Reporter: Matej Kupljen
• Created: 05/Oct/18 09:39
• Updated: 27/Dec/18 15:25
• Resolved: 12/Oct/18 11:36

Description

When using namespaces for c_glib compiler generates incorrect code for #includes.

Example:
first.thrift

namespace c_glib F
  
struct first {
        1: i32 test
}

and second.thrift

namespace c_glib S
  
include "first.thrift"

struct second {
        1: first.first second
}

As you can see, we use namespace F in first.thrift and namespace S in second.thrift.
The compiler generates correct file names for those thrifts:

$ ls gen-c_glib/
f_first_types.c  f_first_types.h  s_second_types.c  s_second_types.h

However, when generating s_second_types.h it uses namespace from second.thrift instead of the one defined for first.thrift when generating #include statement.

/* base includes */
#include <glib-object.h>
#include <thrift/c_glib/thrift_struct.h>
#include <thrift/c_glib/protocol/thrift_protocol.h>
/* other thrift includes */
#include "s_first_types.h"

It should use #include "f_first_types.h"

Issue Links

• links to: GitHub Pull Request #1609