[THRIFT-4620] TZlibTransport.cpp doesn't ensure that there is enough space for the zlib flush marker in the buffer.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.12.0
• Component/s: C++ - Library
• Labels: c++ zlib
• Assignee: James E. King III
• Reporter: Dominic Coyne
• Created: 13/Aug/18 09:23
• Updated: 27/Dec/18 15:25
• Resolved: 16/Sep/18 10:52

Description

I asked this question on stack overflow related to a crash that I have been getting with Thrift.

The problem occurs when using TZlibTransport.cpp. After writing to the buffer a few times, we do a flush. If there isn't enough space in cwbuf_ , the Thrift flush marker is split across two messages, which causes an error in the client, as a deflate stream can't start with a partial flush marker, ff.

Thrift should assure that there will be enough space in the buffer for the complete flush marker, before a deflate.

 

Issue Links

• links to: GitHub Pull Request #1591