Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4620

TZlibTransport.cpp doesn't ensure that there is enough space for the zlib flush marker in the buffer.

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9
    • Fix Version/s: 0.12.0
    • Component/s: C++ - Library
    • Labels:

      Description

      I asked this question on stack overflow related to a crash that I have been getting with Thrift.

      The problem occurs when using TZlibTransport.cpp. After writing to the buffer a few times, we do a flush. If there isn't enough space in cwbuf_ , the Thrift flush marker is split across two messages, which causes an error in the client, as a deflate stream can't start with a partial flush marker, ff.

      Thrift should assure that there will be enough space in the buffer for the complete flush marker, before a deflate.

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jking3 James E. King III
                Reporter:
                ldsrc Dominic Coyne
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: