[THRIFT-4610] [GO] Include directive compiles to language-default import

• Type: Question
• Status: Closed
• Priority: Minor
• Resolution: Invalid
• Affects Version/s: 0.11.0
• Component/s: Go - Compiler
• Assignee: Unassigned
• Reporter: Ermolay Romanov
• Created: 04/Aug/18 18:15
• Updated: 04/Jan/19 03:09
• Resolved: 05/Aug/18 07:44

Description

Thrift IDL utilizing an `include` statement such as:

include "shared.thrift"

creates a golang package that has:

import (
    ...
    "shared"
    ...
)

code.

 

In addition to that, if passing a package= directive to the CLI:

thrift --gen go:package=mommy

the resulting code has an import of the root "mommy" package — I think it replaces not only the gen-go package name with whatever is passed to the CLI but also the name of that import. So it basically tries to import itself.

 

Expected: the code generator would pull needed imports and bundle them with the generated Go code, removing any need for importing anything further.