[THRIFT-4609] keep InnerException wherever appropriate

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.12.0
• Component/s: C# - Library
• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 03/Aug/18 08:25
• Updated: 27/Dec/18 15:24
• Resolved: 07/Aug/18 21:32

Description

The C# Exception type offers the ability to store an InnerException which is sometimes quite helpful for debugging. Hence, wherever appropriate, any exceptions caught and rethrown should be stored into the InnerException field to provide the original error information to the caller.

The only exception (pun intended) to this is TApplicationException - this type is intended to be serialized and sent back to the client. Not only that there is no way to preserve that information, it also could compromise possibly sensitive information to clients, which is a bad thing to happen w/regard to security.

Issue Links

• links to: GitHub Pull Request #1576