[THRIFT-4568] LUA: Missing double endianness conversion

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: Lua - Library
• Labels: LUA
• Patch Info: Patch Available
• Flags: Patch
• Assignee: Unassigned
• Reporter: Felipe Barriga Richards
• Created: 10/May/18 05:52
• Updated: 10/May/18 06:01

Description

On Lua, TBinaryProtocol and TCompactProtocol are using libluabpack.bunpack to pack/unpack double primitives.

The current implementation on luabpack.c is not handling the endianness of the doubles so when it interacts with implementations written on other languages it fails to convert the values.

 A patch has been attached to this ticket. Tests to check the fix are WIP.

Notes:

• The fix is assuming that the size of double is 8 bytes.