[THRIFT-4558] reserved Csharp keywords are not escaped in some cases

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.3, 0.10.0, 0.11.0
• Fix Version/s: 0.12.0
• Component/s: C# - Compiler
• Assignee: Pierre Mignolet
• Reporter: Pierre Mignolet
• Created: 17/Apr/18 13:14
• Updated: 27/Dec/18 15:25
• Resolved: 17/Apr/18 20:15

Description

struct MeMessage {
 1: optional string fixed
 7: required string unchecked
}

Here reserved fixed C# keyword is escaped via @ but unchecked is not escaped in C# code so code is just not compilable

---

I had a look in t_csharp_generator.cc and keyword are present and method normalize_name should make the escape

Issue Links

• links to: GitHub Pull Request #1546