[THRIFT-4555] Getter of binary field in Java creates unnecessary copy

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: Java - Compiler
• Assignee: Unassigned
• Reporter: Joel Croteau
• Created: 13/Apr/18 00:09
• Updated: 27/Dec/18 15:25
• Resolved: 17/Apr/18 06:23

Description

The get[field] method in generated Java code generates a new copy of a binary field every time it is called. This seems incredibly inefficient. Take a simple example struct:

struct StructWithBinary {
       1: required binary field;
}

a portion of the generated code for this is:

  public byte[] getField() {
    setField(org.apache.thrift.TBaseHelper.rightSize(field));
    return field == null ? null : field.array();
  }
...
  public StructWithBinary setField(java.nio.ByteBuffer field) {
    this.field = org.apache.thrift.TBaseHelper.copyBinary(field);
    return this;
  }

So whenever getField is called, setField calls copyBinary and generates another copy. This adds quite a lot of overhead to the getter here and should be fixed.

Issue Links

• links to: GitHub Pull Request #1540