Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4499

Remove Magic Number In TFIleTransport

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 0.11.0
    • 0.12.0
    • Java - Library
    • None

    Description

      Here, the buffer is hard-coded to 8192 (which matches the default value on most JDK implementations). You may wish to remove this magic number and let the JDK decide the size.

      https://github.com/apache/thrift/blob/19baeefd8c38d62085891d7956349601f79448b3/lib/java/src/org/apache/thrift/transport/TFileTransport.java#L369

      Attachments

        1. THRIFT-4499.1.patch
          0.7 kB
          David Mollitor

        Issue Links

          Activity

            People

              jking3 James E. King III
              belugabehr David Mollitor
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: